Repository navigation
chore: improve downstream - #109
Merged
Merged
Conversation
Marcel Kräml (mkraeml)
requested review from
Philip Reinken (philipreinken) and
Patrick Weyck (pweyck)
November 5, 2025 14:25
Philip Reinken (philipreinken)
approved these changes
Nov 5, 2025
Patrick Weyck (pweyck)
approved these changes
Nov 5, 2025
Patrick Weyck (pweyck)
left a comment
Patrick Weyck (pweyck)
left a comment
Contributor
There was a problem hiding this comment.
Nice, I think I've used the logs because it was more portable in theory, but should not matter that much
Marcel Kräml (mkraeml)
force-pushed
the
chore/improve-downstream
branch
2 times, most recently
from
November 6, 2025 08:22
9f0297e to
50fe85a
Compare
Patrick Weyck (pweyck)
approved these changes
Nov 6, 2025
Marcel Kräml (mkraeml)
force-pushed
the
chore/improve-downstream
branch
from
November 6, 2025 09:32
50fe85a to
84159fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we try to get the logs of a run, which are first available after a job is done.
With every try we waste multiple API requests, which exhausts the API rate limit faster.
With this change we search for the Run ID in the job title (needs adjustments in the downstream repo), which doesn't require multiple API requests.
Example run: https://github.com/shopware/shopware/actions/runs/19104786793