Repository navigation
Clarify Store review requirements and submission checks - #2676
Open
Soner (shyim) wants to merge 2 commits into
Open
Soner (shyim) wants to merge 2 commits into
Soner (shyim) wants to merge 2 commits into
Conversation
Developer Docs healthcheckStatus: Completed with |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The removal list still includes webpack.config.js, which is required to resolve Storefront npm dependencies, so following it can leave merchants unable to rebuild.
1 open issue
What changed in this PR
This PR clarifies Shopware Store submission guidance and adds practical verification steps for extension developers.
Changes:
- Add security guidance for authorization, resource ownership, validation, credentials, callbacks, and HTTP methods.
- Expand submission checks for lifecycle behavior, compatibility, sales channels, caching, batching, retries, and consent.
- Correct dependency examples and clarify packaging, logging, styling, indexing, and expected HTTP errors.
| File | Description |
|---|---|
guides/development/testing/store/storefront-performance-and-errors.md |
Clarify dynamic styling, performance checks, and expected error responses |
guides/development/testing/store/store-review-errors.md |
Correct Composer guidance and refine packaging and compatibility checks |
guides/development/testing/store/seo-and-structured-data.md |
Distinguish indexable content from private and utility endpoints |
guides/development/testing/store/security-and-permissions.md |
Add security requirements and verification scenarios |
guides/development/testing/store/quality-guidelines.md |
Add submission checks and guidance for responding to findings |
guides/development/testing/store/not-allowed-store-behaviors.md |
Clarify supported database and filesystem boundaries |
guides/development/testing/store/installation-and-cleanup.md |
Expand cleanup, ownership, update, and lifecycle checks |
guides/development/testing/store/index.md |
Link the new security guidance |
guides/development/testing/store/functionality-integration.md |
Expand integration, channel, cache, batching, and queue guidance |
guides/development/testing/store/cookies-and-privacy.md |
Add consent enforcement and withdrawal checks |
guides/development/testing/store/code-quality.md |
Clarify logging destinations and release contents |
.wordlist.txt |
Add terminology used by the updated documentation |
Review effort: Balanced
| Keep required production build manifests and the `checksum.json` generated by release tooling; distinguish them from development caches. | ||
| Usage documentation and changelogs are not unused artifacts merely because they are Markdown files. | ||
|
|
||
| The following are common development or temporary artifacts to remove when present in the release archive: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Corrects outdated and overly broad Store guidance and adds concrete verification steps for extension developers. For example, the dependency guidance now uses valid Composer JSON and tested version ranges instead of a wildcard
shopware/frontenddependency; packaging guidance distinguishes required source/build manifests from development-only artifacts.Related links
Checklist
PageRefreferences where relevant..gitbook.yamlif pages were moved, renamed, or deleted. (Not applicable: existing page paths are preserved; the replaced heading retains its anchor.).wordlist.txt(and sorted it) if spellcheck flags new legitimate terms.Dependent PRs
Notes
Validation passed:
pnpm run check:markdown).git diff --check.Draft for review of the clarified requirement wording, particularly packaging exceptions, supported SQL use, and the distinction between recommendations and submission requirements. No private review discussions or partner extension source are included.