Repository navigation
docs: Pass sales channel entities to SEO URL persistence - #2656
Merged
Su (sushmangupta) merged 2 commits intoOct 23, 2026
Merged
Su (sushmangupta) merged 2 commits into
Su (sushmangupta) merged 2 commits into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Developer Docs healthcheckStatus: Completed with |
Developer Docs healthcheckStatus: Running. |
Contributor
📢 Developer Announcement RecommendationRecommendation: ❌ No Announcement Recommended No developer announcement signals were detected.
|
Bojan Rajh (bojanrajh)
approved these changes
Oct 22, 2026
Su (sushmangupta)
approved these changes
Oct 22, 2026
Su (sushmangupta)
deleted the
docs/pass-sales-channel-entities-to-seo-url-persistence
branch
October 23, 2026 07:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepareCriteria(Criteria $criteria, SalesChannelEntity $salesChannel): void; the 6.7.15.1 interface requires that parameter, and the generator passes it.SalesChannelEntitybefore callingupdateSeoUrlswith five arguments. Copying the original call omitted the required sales channel parameter.SalesChannelEntityand passes it toupdateSeoUrls, which uses its ID when marking URLs as deleted.Related links
add-custom-seo-url.mdL206add-custom-seo-url.mdL522add-custom-seo-url.mdL554v6.7.15.1):EntitySeoUrlRouteInterface.phpL13-L17: The interface requiresprepareCriteriato accept aSalesChannelEntity.SeoUrlGenerator.phpL72-L73: The generator passes the sales channel entity toprepareCriteria.SeoUrlPersister.phpL43-L45:updateSeoUrlsrequires a fifth argument of typeSalesChannelEntity.EntityRepository.phpL66-L68: The repository provides thesearchmethod used to retrieve the sales channel entity.SeoUrlPersister.phpL87-L88: The persister gets the sales channel ID from the required entity.SeoUrlPersister.phpL160-L164: The persister uses the sales channel ID when marking SEO URLs as deleted.Checklist
PageRefreferences where relevant. (Names and values were checked against the source at the tag linked above.).gitbook.yamlif pages were moved, renamed, or deleted. (N/A, no page moved.).wordlist.txt(and sorted it) if spellcheck flags new legitimate terms. (No new prose words.)Notes
v6.7.15.1):src/Core/Content/Seo/SeoUrlGenerator.phpL72-L73;src/Core/Content/Seo/SeoUrlPersister.phpL160-L164;src/Core/Content/Seo/SeoUrlPersister.phpL43-L45;src/Core/Content/Seo/SeoUrlPersister.phpL87-L88;src/Core/Content/Seo/SeoUrlRoute/EntitySeoUrlRouteInterface.phpL13-L17;src/Core/Framework/DataAbstractionLayer/EntityRepository.phpL66-L68.shopware/shopwareat tagv6.7.15.1, then an independent re-check by a second AI model that re-read the page and the cited source files. Please check the cited lines yourself before merging.main(Shopware 6.7) only. Older docs branches are not touched.🤖 Generated with Claude Code