Skip to content

docs: Pass sales channel entities to SEO URL persistence - #2656

Merged
Su (sushmangupta) merged 2 commits into
mainfrom
docs/pass-sales-channel-entities-to-seo-url-persistence
Oct 23, 2026
Merged

Su (sushmangupta) merged 2 commits into
mainfrom
docs/pass-sales-channel-entities-to-seo-url-persistence

Conversation

@d-kirkland

Copy link
Copy Markdown
Contributor

Summary

  • The page now declares prepareCriteria(Criteria $criteria, SalesChannelEntity $salesChannel): void; the 6.7.15.1 interface requires that parameter, and the generator passes it.
  • The page now retrieves a SalesChannelEntity before calling updateSeoUrls with five arguments. Copying the original call omitted the required sales channel parameter.
  • The deletion example now accepts a SalesChannelEntity and passes it to updateSeoUrls, which uses its ID when marking URLs as deleted.
  • The edits update the route signature and its description, add the sales channel lookup and fifth argument to the write example, and add the entity parameter and fifth argument to the deletion example.

Related links

Checklist

  • I reviewed affected links, code samples, and cross-references, including PageRef references where relevant. (Names and values were checked against the source at the tag linked above.)
  • I added or updated redirects in .gitbook.yaml if pages were moved, renamed, or deleted. (N/A, no page moved.)
  • I updated .wordlist.txt (and sorted it) if spellcheck flags new legitimate terms. (No new prose words.)
  • Any required dependent changes in downstream modules have already been merged and published. (N/A)
  • This pull request is ready for review.

Notes

  • This PR was fully AI generated and requires human review. The text was drafted by an OpenAI model (gpt-6-luna) and checked by a second OpenAI model (gpt-6.1-sol), run from a Claude Code session. It has not been merged, approved or reviewed by a person. Please verify the claims and the changed text against the source before merging.
  • Defect type: Breaks (3 of 3 changes). A reader who follows the page as written ends up with code, markup or a command that fails or does not do what the page says.
  • Codebase files this change was checked against (tag v6.7.15.1): src/Core/Content/Seo/SeoUrlGenerator.php L72-L73; src/Core/Content/Seo/SeoUrlPersister.php L160-L164; src/Core/Content/Seo/SeoUrlPersister.php L43-L45; src/Core/Content/Seo/SeoUrlPersister.php L87-L88; src/Core/Content/Seo/SeoUrlRoute/EntitySeoUrlRouteInterface.php L13-L17; src/Core/Framework/DataAbstractionLayer/EntityRepository.php L66-L68.
  • How it was found: a read-through of this page against shopware/shopware at tag v6.7.15.1, then an independent re-check by a second AI model that re-read the page and the cited source files. Please check the cited lines yourself before merging.
  • Scope: main (Shopware 6.7) only. Older docs branches are not touched.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@d-kirkland Daniel Kirkland (d-kirkland) added Improvement PR created to append/modify info in the existing article Info Missed To Document Info Missed To Document labels Oct 22, 2026
@shopware-dev-docs-connector

shopware-dev-docs-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Developer Docs healthcheck

Status: Completed with success.
Repository: shopware/docs
Commit: 2544c49
Preview: https://developer-documentation-jle8340oc-shopware-frontends.vercel.app
Workflow run: #5818

@shopware-dev-docs-connector

Copy link
Copy Markdown

Developer Docs healthcheck

Status: Running.
Repository: shopware/docs
Commit: bc179fe
Preview: Waiting for workflow logs.

@github-actions

Copy link
Copy Markdown
Contributor

📢 Developer Announcement Recommendation

Recommendation: ❌ No Announcement Recommended

No developer announcement signals were detected.

This PR does not appear to introduce developer-facing changes that require a community announcement.

@sushmangupta
Su (sushmangupta) merged commit ffba0f2 into main Oct 23, 2026
10 checks passed
@sushmangupta
Su (sushmangupta) deleted the docs/pass-sales-channel-entities-to-seo-url-persistence branch October 23, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement PR created to append/modify info in the existing article Info Missed To Document Info Missed To Document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants