Skip to content

[Owner decision needed] docs: Redis maxmemory-policy recommendations contradict each other (volatile-lfu vs volatile-lru) - #2590

Merged
Su (sushmangupta) merged 3 commits into
mainfrom
fix/docs-redis-eviction-policy-contradiction-draft
Oct 23, 2026
Merged

Su (sushmangupta) merged 3 commits into
mainfrom
fix/docs-redis-eviction-policy-contradiction-draft

Conversation

@d-kirkland

@d-kirkland Daniel Kirkland (d-kirkland) commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Owner confirmation needed. This PR applies one possible resolution. The platform source cannot decide which is right, so please confirm the rule with the owners before merging.

What the platform source says

No PHP code or configuration sets or requires a policy. The only statement is the development compose.yaml: v6.7.15.1 L67 runs the Valkey service with --maxmemory-policy volatile-lfu (same at v6.6.10.29 L65; v6.5.8.19 has none). That matches the lfu row but is a development default, not a recommendation, and it does not show lru to be wrong. The platform therefore cannot decide.

Options for the owner

  1. Per-use policies are the intended advice (redis.md): the requirements table should not name a single policy. This is what the diff in this PR does (the table row points to the Redis page).
  2. volatile-lfu is the intended advice for cache data: redis.md, caches.md, cart-storage.md, increment.md and number-ranges.md must be changed (this is a larger edit than this PR).
  3. volatile-lru is intended and lfu is wrong: change only the requirements table (and requirements.md on v6.6/v6.5).

Nothing in this PR is a verified fact about which policy is better.

Checklist

  • I reviewed affected links, code samples, and cross-references, including PageRef references where relevant. (The new relative link was resolved from the page's folder.)
  • I added or updated redirects in .gitbook.yaml if pages were moved, renamed, or deleted. (N/A)
  • I updated .wordlist.txt (and sorted it) if spellcheck flags new legitimate terms. (No new words.)
  • Any required dependent changes in downstream modules have already been merged and published. (N/A)
  • This pull request is ready for review. (The rule still needs the owners' confirmation, see the top of this description.)

Notes

  • This PR was fully AI generated (Claude Code) and requires human review. It has not been merged, approved or reviewed by the AI session.
  • Scope: main. v6.6 has the same lfu vs lru disagreement (requirements page vs Redis pages); v6.5 states only lfu, so there is no internal contradiction there. Backports are deliberately not opened until the rule is decided.
  • Marked ready for review on request. Please confirm the rule, then adopt, change or close this PR.

🤖 Generated with Claude Code

… (draft, owner decision)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@d-kirkland Daniel Kirkland (d-kirkland) added Improvement PR created to append/modify info in the existing article Info Missed To Document Info Missed To Document labels Oct 13, 2026
@shopware-dev-docs-connector

shopware-dev-docs-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Developer Docs healthcheck

Status: Completed with success.
Repository: shopware/docs
Commit: 9bad7e8
Preview: https://developer-documentation-avmvx32yv-shopware-frontends.vercel.app
Workflow run: #5815

@github-actions

Copy link
Copy Markdown
Contributor

📢 Developer Announcement Recommendation

Recommendation: ❌ No Announcement Recommended

No developer announcement signals were detected.

This PR does not appear to introduce developer-facing changes that require a community announcement.

@sushmangupta
Su (sushmangupta) merged commit 2318d97 into main Oct 23, 2026
10 checks passed
@sushmangupta
Su (sushmangupta) deleted the fix/docs-redis-eviction-policy-contradiction-draft branch October 23, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement PR created to append/modify info in the existing article Info Missed To Document Info Missed To Document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants