Limit to 10k-short-URL batches when backfilling long_url_hash - #2632
Merged
Conversation
acelaya
marked this pull request as draft
June 20, 2026 09:48
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2632 +/- ##
==========================================
Coverage 94.21% 94.21%
Complexity 1605 1605
==========================================
Files 273 273
Lines 5017 5017
==========================================
Hits 4727 4727
Misses 290 290 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
acelaya
marked this pull request as ready for review
June 22, 2026 14:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #2620 (comment)
Closes #2634
Update migration responsible of backfilling the
long_url_hashcolumn in short URLs, so that it fetches existing short URLs in batches of 10k.This prevents selects which can potentially return millions of results, and removes the need to manually track the amount of updates per transaction, since it becomes implicit.