chore: modernize golangci-lint config#55
Merged
Conversation
akshaykalia
force-pushed
the
chore/modernize-golangci-lint
branch
from
045eadf to
fd440a4
Compare
- Replace dead .golangci.yml.old with active .golangci.yml (v2 format) - Enable additional linters that pass cleanly: bodyclose, misspell, nilerr, unconvert, wastedassign - Update CI from golangci-lint v1.56 (EOL) to v2.1 - Update action from golangci-lint-action@v3 to @v6 All new linters produce zero findings on the current codebase. They catch HTTP body leaks (bodyclose), swallowed errors (nilerr), typos (misspell), and dead assignments (wastedassign) in future code.
akshaykalia
force-pushed
the
chore/modernize-golangci-lint
branch
from
fd440a4 to
fa2ae3a
Compare
akshaykalia
added a commit
that referenced
this pull request
Jun 8, 2026
Resolve conflicts between UI enhancements and main branch updates: - Take golangci-lint v2.1 from modernization PR (#55) - Keep review fix: remove auth test-mode bypass - Keep review fix: improved test error handling - Take main's refactored update command - Reconcile dependency versions via go mod tidy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.golangci.yml.oldwith an active.golangci.ymlin v2 formatbodyclose,misspell,nilerr,unconvert,wastedassignWhat these linters catch in future code
bodyclosenilerrmisspellunconvertwastedassignTest plan
golangci-lint runproduces 0 findings from new lintersgo build ./...passesgo test ./...passes