Repository navigation
Surface terminal transcription failures instead of swallowing them - #34
Merged
Merged
Conversation
The cloud instance returned 403 FEATURE_UNAVAILABLE from the transcription routes for weeks and the app never told anyone: segment registration treated it as a quiet no, the stop path converted any transcribe failure into a silent success, and startup recovery only ran on a sign-in transition and swallowed every error, so an orphaned capture retried invisibly forever. Responses now flow through one classified seam: 403 with the FEATURE_UNAVAILABLE code is terminal and surfaced (host-named stop error, once-per-recording banner while capture continues, one recovery notification per directory); bare 401 keeps the token-refresh path; a 403 with an unparseable body is terminal rather than an auth retry so a proxy-mangled response cannot degrade into a thousand silent retries. The stop path rethrows every transcribe failure into the error state with Retry. Recovery runs on every launch after session restore, persists an attempt counter in the capture manifest, and after five failed attempts notifies once and stops sweeping, keeping the audio. Audio is never deleted on any of these paths. Tests 263 -> 286.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client half of the prod transcription outage. app.getminutia.com returned 403
FEATURE_UNAVAILABLEfrom the transcription routes for weeks and the app never told anyone: segment registration treated it as a quiet no, the stop path converted any transcribe failure into a silent success, and startup recovery only ran on a sign-in transition and swallowed every error, so an orphaned capture retried invisibly forever.classify(status:body:)): 403 +FEATURE_UNAVAILABLEcode is terminal and surfaced; bare 401 keeps the token-refresh path; 403 with an unparseable body is terminal rather than auth-retry, so a proxy-mangled response cannot degrade into ~1000 silent retries.Tests 263 → 286. Two independent reviews (correctness, silent-failure hunt); all findings fixed and re-verified. Rebased over #33; full suite green post-rebase.