Repository navigation
fix(stream): log mqtt close error at Debug level (closes #19) - #25
Closed
openclaw-bot-mary wants to merge 1 commit into
Closed
openclaw-bot-mary wants to merge 1 commit into
openclaw-bot-mary wants to merge 1 commit into
Conversation
shing1211
approved these changes
Oct 8, 2026
shing1211
left a comment
shing1211
left a comment
Owner
There was a problem hiding this comment.
✅ #25 — APPROVE
Tier: 1 (silent — code hygiene fix)
Gate: go build ./... && go vet ./... → confirmed clean by Bill's automation
Findings: none
Protocol: tests→post-conditions [none]; counters→source+recompute [none]; comparisons→row-hash [none]
Carve-out: none
Reviewed-head: fix/issue19-ignored-error
Next: merged
Collaborator
Author
|
Closing — fix is already on main via commit 5017a08. See change fix-webullapi4go-issues for the full audit and remaining reliability fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(stream): log mqtt close error at Debug level (closes #19)
What
stream/client.go:279— themqtt.Close()error was silently discarded with_ =.Replaced with a Debug-level log:
slog.Debug("mqtt close failed", "err", err). Thispreserves the best-effort semantics (close proceeds regardless) while making a
non-nil error visible when debug logging is active.
Why Debug level
Close is best-effort during teardown; most closes succeed normally. Logging every
close at Info would be noise. Debug captures the rare failure case without
poluting normal output.
Gate
go build ./...✓go vet ./...✓Closes #19