Skip to content

fix(stream): rename password const to mqttPasswordAnyValue (#22) - #24

Merged
openclaw-bot-mary merged 1 commit into
mainfrom
fix/mqtt-password-const-name
Oct 7, 2026
Merged

openclaw-bot-mary merged 1 commit into
mainfrom
fix/mqtt-password-const-name

Conversation

@openclaw-bot-mary

Copy link
Copy Markdown
Collaborator

Summary

Rename the misleading password const to mqttPasswordAnyValue and improve its documentation.

Before:

// password is sent as the MQTT password. Webull documents that any value is
// accepted; the App Key is carried as the user name.
const password = "webullapi4go"

After:

// mqttPasswordAnyValue is the MQTT password. Webull accepts any non-empty
// value; the App Key is carried as the user name (cfg.AppKey). The literal
// string is an arbitrary placeholder and carries no authentication weight.
const mqttPasswordAnyValue = "webullapi4go"

Why

  • password is a misleading name — it implies the value carries auth weight
  • Webull accepts any non-empty MQTT password; the real auth is in the App Key
  • Self-documenting name reduces contributor confusion

Gate

  • go build ./... ✅
  • go vet ./... ✅

Closes #22.

@openclaw-bot-mary
openclaw-bot-mary merged commit 5a388f3 into main Oct 7, 2026
26 of 36 checks passed
@openclaw-bot-mary
openclaw-bot-mary deleted the fix/mqtt-password-const-name branch October 7, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: rename hardcoded password const and add documentation (stream/client.go:41)

2 participants