Skip to content

ci: compute coverage gate from profile, not 'go tool cover -func' total #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shinagawa-web merged 2 commits into from
Jul 2, 2026
Merged

ci: compute coverage gate from profile, not 'go tool cover -func' total #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e707f3e
ci: compute coverage gate from profile, not 'go tool cover -func' total
shinagawa-web Jul 2, 2026
e40213e
ci: fail check-coverage on test failure; assert --format error message
shinagawa-web Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,11 @@ update-golden: build-e2e ## Regenerate golden files for pattern battery tests

check-coverage: ## Run tests with coverage and enforce minimum threshold
@echo "Running tests with coverage (threshold: $(COVERAGE_THRESHOLD)%)..."
@coverage_file=$$(mktemp); \
@set -e; \
coverage_file=$$(mktemp); \
trap 'rm -f "$$coverage_file"' EXIT; \
$(GOTEST) $$(go list ./... | grep -v /e2e) -coverprofile="$$coverage_file"; \
total=$$($(GOCMD) tool cover -func="$$coverage_file" | grep '^total' | awk '{print $$3}' | tr -d '%'); \
total=$$(awk 'NR>1 { tot+=$$2; if ($$3>0) cov+=$$2 } END { if (tot>0) printf "%.1f", 100*cov/tot; else print "0.0" }' "$$coverage_file"); \
echo "Total coverage: $${total}%"; \
if ! awk "BEGIN { exit !($$total >= $(COVERAGE_THRESHOLD)) }"; then \
echo "FAIL: coverage $${total}% is below threshold $(COVERAGE_THRESHOLD)%"; exit 1; \
Expand Down
6 changes: 5 additions & 1 deletion cmd/colref/check_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,9 +790,13 @@ func TestCheckCmd_RunE_InvalidFormat(t *testing.T) {
"--orm", "django",
"--format", "xml",
})
if err := rootCmd.Execute(); err == nil {
err := rootCmd.Execute()
if err == nil {
t.Fatal("expected error for invalid --format")
}
if !strings.Contains(err.Error(), `unknown --format "xml"`) {
t.Fatalf("error is not the --format validation failure: %v", err)
}
}

func TestCheckCmd_RunE_InvalidColor(t *testing.T) {
Expand Down