Skip to content

fix(hooks): detach fish hook from the tty #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnnatarHe merged 1 commit into from
Aug 5, 2026
Merged

fix(hooks): detach fish hook from the tty #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions model/hooks/fish.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
if not command -v shelltime > /dev/null
echo "Warning: shelltime CLI not found. Please install it to enable time tracking."
else
shelltime gc
# Detached from the tty: this runs while fish is still probing the terminal
# (OSC 11 / CPR / DA1) at startup, and must not sit on the input queue.
shelltime gc < /dev/null
end

# Create a timestamp for the session when the shell starts
Expand All @@ -19,7 +21,7 @@ function fish_preexec --on-event fish_preexec
return
end

shelltime track -s=fish -id=$SESSION_ID -cmd="$argv" -p=pre --ppid=$FISH_PPID > /dev/null
shelltime track -s=fish -id=$SESSION_ID -cmd="$argv" -p=pre --ppid=$FISH_PPID < /dev/null > /dev/null 2>&1
end

# Define the postexec function
Expand All @@ -29,5 +31,5 @@ function fish_postexec --on-event fish_postexec
return
end
# This event is triggered before each prompt, which is after each command
shelltime track -s=fish -id=$SESSION_ID -cmd="$argv" -p=post -r=$LAST_RESULT --ppid=$FISH_PPID > /dev/null
shelltime track -s=fish -id=$SESSION_ID -cmd="$argv" -p=post -r=$LAST_RESULT --ppid=$FISH_PPID < /dev/null > /dev/null 2>&1
end
Loading