Repository navigation
Share desktop and MCP engine commands and strengthen render regressions - #23
Open
sheldonxxxx wants to merge 1 commit into
Open
sheldonxxxx wants to merge 1 commit into
sheldonxxxx wants to merge 1 commit into
Conversation
Route desktop and MCP operations through a versioned native command contract. Unify sampled crop origins, visible mask preparation, final precision and encoding, with independent CPU fixtures and explicit GPU CI gates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop and MCP editing now use a versioned Open/Adjust/Mask/Render/Export contract. This centralizes source geometry, visible-mask preparation, final-render precision and encoding while keeping session/revision and output-path rules in the MCP adapter. Cropped masks now use the sampled pixel origin, and final exports reject incomplete mask rasterization.
The regression suite adds independent CPU expectations for geometry, masks and exposure, plus targeted GPU checks for 16-bit precision, preview parity, ROI failures, PNG/TIFF sample fidelity and embedded sRGB profiles. The MCP workflow explicitly runs the three GPU regression tests on macOS.
Validation:
cargo fmt --check, strict all-targets/all-features Clippy, and Rust tests with default and MCP features.Hosted CI: all 13 checks passed, including Apple Silicon, Ubuntu 22.04 and Ubuntu 24.04 package builds, the package build gate, and all three Metal GPU regressions.