Skip to content

fix(mcp): continue after requests rejected before execution - #21

Merged
sheldonxxxx merged 1 commit into
devfrom
codex/mcp-client-rejections-20261008
Oct 8, 2026
Merged

sheldonxxxx merged 1 commit into
devfrom
codex/mcp-client-rejections-20261008

Conversation

@sheldonxxxx

Copy link
Copy Markdown
Owner

Problem and result

The persistent MCP skill client exits after recoverable rejected requests, forcing a reconnect before the next edit. It now keeps reading after schema validation and the known pre-execution errors INVALID_ARGUMENT, REVISION_CONFLICT, JOB_BUSY, and MODEL_NOT_INSTALLED.

Other MCP result errors still stop queued edits by default. --continue-on-error permits continuing when each request is sent and inspected individually; transport failures and timeouts always stop the client.

Type of Change

  • Bug fix
  • Breaking change
  • Documentation update

Changes

  • Replace --on-rejected with default rejection handling and the --continue-on-error override. Existing launch commands using --on-rejected must be updated.
  • Keep rejection messages distinct from errors that may require state inspection.
  • Update regression coverage and connection guidance.
  • Refine the skill's masking and measurement instructions with conservative defaults and gradient/gap guidance; native tool capabilities are unchanged.

Testing

The following passed on the PR branch against dev:

  • npm run format:check, npm run typecheck, npm run lint, and npm run i18n:check.
  • npm test: 133 frontend tests.
  • npm test --prefix mcp: 149 MCP tests, including continued schema rejection, stopping on native errors, explicit error continuation, and transport handling.
  • Commit whitespace checks.

Test Configuration:

  • OS and architecture: macOS 27.0, arm64; Node 26.9.0.
  • GPU / processing backend: Not used by the client tests.
  • Affected entry point: MCP skill stdio client.
  • MCP host and native build: TypeScript host built by the test command; error-handling tests use a controlled test engine. These tests do not claim native photographic acceptance.

Checklist

  • Code follows the project's style and checks pass without warnings.
  • No unnecessary AI-generated code comments were added.
  • README/setup claims remain accurate and behaviour changes are recorded under Unreleased in CHANGELOG.md.
  • Shared files and links contain no credentials, personal paths, or unavailable local evidence.

AI assistance

Prepared with Codex assistance. The diff and local checks were reviewed, and a separate product manager reviewed the public guidance and messaging.

Keep the skill client open after known pre-execution rejections. Add --continue-on-error for other MCP result errors while stopping on transport failures and timeouts. Update connection and local-masking guidance and regression coverage.

BREAKING CHANGE: replace --on-rejected with default rejection handling and --continue-on-error.
@sheldonxxxx
sheldonxxxx merged commit 19dc78c into dev Oct 8, 2026
12 checks passed
sheldonxxxx added a commit that referenced this pull request Oct 8, 2026
Preserve unpublished connector work while recording the merged MCP client history. The resulting source tree is unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant