Repository navigation
fix(mcp): continue after requests rejected before execution - #21
Merged
Merged
Conversation
Keep the skill client open after known pre-execution rejections. Add --continue-on-error for other MCP result errors while stopping on transport failures and timeouts. Update connection and local-masking guidance and regression coverage. BREAKING CHANGE: replace --on-rejected with default rejection handling and --continue-on-error.
sheldonxxxx
added a commit
that referenced
this pull request
Oct 8, 2026
Preserve unpublished connector work while recording the merged MCP client history. The resulting source tree is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
The persistent MCP skill client exits after recoverable rejected requests, forcing a reconnect before the next edit. It now keeps reading after schema validation and the known pre-execution errors
INVALID_ARGUMENT,REVISION_CONFLICT,JOB_BUSY, andMODEL_NOT_INSTALLED.Other MCP result errors still stop queued edits by default.
--continue-on-errorpermits continuing when each request is sent and inspected individually; transport failures and timeouts always stop the client.Type of Change
Changes
--on-rejectedwith default rejection handling and the--continue-on-erroroverride. Existing launch commands using--on-rejectedmust be updated.Testing
The following passed on the PR branch against
dev:npm run format:check,npm run typecheck,npm run lint, andnpm run i18n:check.npm test: 133 frontend tests.npm test --prefix mcp: 149 MCP tests, including continued schema rejection, stopping on native errors, explicit error continuation, and transport handling.Test Configuration:
Checklist
AI assistance
Prepared with Codex assistance. The diff and local checks were reviewed, and a separate product manager reviewed the public guidance and messaging.