Repository navigation
fix: crop Sony lossless M/S ARWs correctly (green borders) - #20
Merged
Merged
Conversation
Pin rawler via [patch] to the default-crop fix from CyberTimon/RapidRAW-DngLab#7 (Kheil-Z), rebased onto the currently pinned rawler 934af4b so nothing else changes. Sony lossless M/S ARWs are 3-channel and tile-padded; the crop was rescaled by the active-area width as if the active area had been cropped, which stretched it over the padding (CyberTimon#850, CyberTimon#1300). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Owner
|
Sorry for the late reply! I didn’t get a notification for this PR and only noticed it when it appeared in ChatGPT’s suggested tasks. Just to clarify, I haven’t run any formal benchmarks for Nonlocal denoise. I chose it after a few rounds of experimentation, comparing the results visually with the native denoising in upstream RapidRAW and darktable. This fork is mostly a playground where I throw ideas at AI and see what we can build. But yes, I’d be happy to collaborate, share what I’ve tried, and compare notes. Thanks for reaching out—and for the fix! |
sheldonxxxx
added a commit
that referenced
this pull request
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sony lossless compressed M/S ARWs come out with green bars on the right and bottom (CyberTimon#850, CyberTimon#1300). This fork has the same problem: it pins rawler at
934af4b, the same as upstream.Cause: these files are 3-channel (
cpp == 3,LinearRaw) and tile-padded, so RapidRAW drops the Demosaic step for them. The rawler fork'sCropDefaultthen rescales the crop byintermediate width / active-area width, as if the active area had already been cropped. The crop gets stretched (ILCE-7CR S: 5120/4784, so 5085×3390 instead of 4752×3168) and takes in the tile padding, which renders green.Fix: pin rawler via
[patch]to the change from CyberTimon/RapidRAW-DngLab#7 (Kheil-Z, written for Canon mRAW/sRAW; same root cause). It only uses the active-area width when Demosaic actually ran. #7's branch is based on an older rawler than the934af4bthis fork pins, and pinning it directly would also revert934af4b's unbounded-highlights change inraw.rs. So I cherry-picked its two commits, keeping Kheil-Z as author, onto934af4bat yojen7/RapidRAW-DngLab@fe08395: a 6-linedevelop.rschange and nothing else. Cargo-only change: the[patch]insrc-tauri/Cargo.tomland a one-lineCargo.lockupdate (valid with--locked). Drop it once #7 is merged upstream and rawler is bumped.Testing (this branch, Linux x86_64,
npm run tauri build -- --no-bundle, headlessrapidraw-mcp export … --format tiff)DefaultCrop4752×3168 @ (16,10)DefaultCrop4320×2880 @ (8,8)The build left
Cargo.lockunchanged after the one-line edit, and output is byte-identical to building directly against #7's branch head.On upstream RapidRAW
mainwith the same patch, our 20-raw regression corpus (Sony A7C II/A7CR in several modes, Canon CR3, Nikon, Fuji X-Trans, OM-1, Panasonic, phone DNGs) × 3 adjustment sets was pixel-identical apart from the ILCE-7CR S file. I didn't rerun the full corpus on this fork.Hello 👋
I'm also building on RapidRAW with AI agents (Linux, Sony A7C II), and I've been following this fork: the MCP server and your Nonlocal denoise study are impressive. We've been working on overlapping things:
Would you be open to coordinating, e.g. sharing benchmark results and combining efforts, so we're not maintaining parallel forks? Issues are disabled here, so this PR seemed like the best way to say hi.
AI disclosure
Created by an AI agent (Claude Code); a human reviewed the change and results.
🤖 Generated with Claude Code