Fix wear "Failed to load": read response bodies inside the IO context#20
Merged
Conversation
Mirror the phone module's debug network security config in the wear module, so debug watch builds can talk to a local dev server over plain http on localhost/127.0.0.1/10.0.2.2. Release builds are unaffected.
OkHttp's execute() returns once headers arrive; body.string() still reads from the socket, so reading it on Main threw NetworkOnMainThreadException for any response that wasn't already buffered - reliably for member lists, intermittently for login. Drain bodies in the same IO context as the call, and log the previously swallowed failures in the store and login screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OkHttp's execute() returns once headers arrive; body.string() still reads from the socket, so reading it on Main threw NetworkOnMainThreadException for any response that wasn't already buffered - reliably for member lists, intermittently for login. Drain bodies in the same IO context as the call, and log the previously swallowed failures in the store and login screen.