Fix raceAbort masking non-Error rejections, add coverage gate#76
Merged
Conversation
The promise's own rejection reason was being coerced with toError, which defaults non-Error reasons to AbortError. That's only correct for abort reasons, not genuine rejections, so a thrown non-Error value (e.g. a rejected string) was misreported as a cancellation. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Wire vitest coverage-v8 with per-metric thresholds (mirroring the open-board-format sibling package) into CI/release, and add missing tests for the create*() factories and measureInput() that the new coverage gate surfaced as untested. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
raceAbortcoercing genuine (non-Error) promise rejections intoAbortError, so a rejected non-Error value is no longer misreported as a cancellation@vitest/coverage-v8with per-metric thresholds (mirroring theopen-board-formatsibling package) and wiretest:coverageinto CI/releasecreate*()factories andmeasureInput()that the new coverage gate surfaced as untestedTest plan
npm run test:coveragepasses with thresholds metnpm run typechecknpm run lint🤖 Generated with Claude Code