Skip to content

fix: improve regex comment for URL matching efficiency #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharma-open-source merged 1 commit into from
Jun 27, 2026
Merged

fix: improve regex comment for URL matching efficiency #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/egress/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ export interface EgressResult {
}

// Matches markdown images ![alt](url) and bare http/https/ftp URLs.
const URL_RE = /!\[([^\]]*)\]\(\s*([^)\s]+)(?:\s+"[^"]*")?\)|(?:https?|ftp):\/\/[^\s)<>"']+/g;
// Alt excludes '[' and the image URL excludes '(' so a partial "![..." / "![](..."
// start that never completes fails in O(1) instead of re-scanning to the end of the
// input, which would make matching quadratic on adversarial egress text (ReDoS).
const URL_RE = /!\[([^\]\[]*)\]\(\s*([^)\s(]+)(?:\s+"[^"]*")?\)|(?:https?|ftp):\/\/[^\s)<>"']+/g;

function urlAllowed(url: string, allowlist: (string | RegExp)[]): boolean {
return allowlist.some((entry) => {
Expand Down
Loading