Skip to content

Fix: Ensure correct component is matched during validation - #1

Merged
shanthropic merged 1 commit into
mainfrom
fix-component-validation
Nov 15, 2025
Merged

Fix: Ensure correct component is matched during validation#1
shanthropic merged 1 commit into
mainfrom
fix-component-validation

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

This submission fixes a bug in the component validation logic. The validateWebsite function was incorrectly identifying components when one component's name was a substring of another. This was due to the component list not being sorted by length, causing, for example, <md-icon-button> to be matched with the icon component instead of icon-button. This commit sorts the component list by length in descending order before matching, ensuring the most specific component is always chosen. Additionally, the extractApi function was corrected to use the 'Attribute' column instead of the 'Property' column from the API documentation, aligning the validation with the actual HTML attributes. A new test case was added to verify the fix.


PR created automatically by Jules for task 11059292876308023292 started by @shantoislamdev

The `validateWebsite` function was incorrectly identifying components
when one component's name was a substring of another. This was due to
the component list not being sorted by length, causing, for example,
`<md-icon-button>` to be matched with the `icon` component instead of
`icon-button`.

This commit sorts the component list by length in descending order
before matching, ensuring the most specific component is always chosen.

Additionally, the `extractApi` function was corrected to use the
'Attribute' column instead of the 'Property' column from the API
documentation, aligning the validation with the actual HTML attributes.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@shanthropic shanthropic changed the title Fix component validation logic Fix: Ensure correct component is matched during validation Nov 15, 2025
@shanthropic
shanthropic marked this pull request as ready for review November 15, 2025 16:37
@shanthropic
shanthropic merged commit 394a149 into main Nov 15, 2025
5 checks passed
shanthropic added a commit that referenced this pull request Jan 23, 2026
Fix: Ensure correct component is matched during validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant