- fix mac task icon creation (see desc) - #475
Merged
Merged
Conversation
- The diff touches **only** `MacBundler.java` (43+/16−, one file).
- Windows has a completely separate path: `InstallWindows.java:193` reads `icon.png` from the bundle dir and encodes a `.ico` via image4j's `ICOEncoder`. Linux just points `Icon={{APP_ICON}}` in the `.desktop` file at `icon.png`. Neither goes near `MacBundler`.
- Both new file operations (`createThumbnails`, `cleanThumbnails`) work strictly inside the mac bundle's `Contents/`, which no other platform reads. The thumbnails are files `MacBundler` itself just created, and `iconFile.delete()` was already there.
- The change uses only `Thumbnails` (Thumbnailator) and `IcnsType`/`IcnsBuilder` — pure Java, no `iconutil` or other macOS tooling. So mac bundles still build correctly from Linux/Windows CI. (`iconutil` appeared only in my ADM script and my verification, never in the jdeploy patch.)
Owner
|
Thanks @jpage4500 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MacBundler.java(43+/16−, one file).InstallWindows.java:193readsicon.pngfrom the bundle dir and encodes a.icovia image4j'sICOEncoder. Linux just pointsIcon={{APP_ICON}}in the.desktopfile aticon.png. Neither goes nearMacBundler.createThumbnails,cleanThumbnails) work strictly inside the mac bundle'sContents/, which no other platform reads. The thumbnails are filesMacBundleritself just created, andiconFile.delete()was already there.Thumbnails(Thumbnailator) andIcnsType/IcnsBuilder— pure Java, noiconutilor other macOS tooling. So mac bundles still build correctly from Linux/Windows CI. (iconutilappeared only in my ADM script and my verification, never in the jdeploy patch.)