Skip to content

Refactor Helper application logic to use services instead of commands - #428

Merged
shannah merged 1 commit into
masterfrom
claude/fix-helper-directory-creation-bEwOm
Mar 8, 2026
Merged

shannah merged 1 commit into
masterfrom
claude/fix-helper-directory-creation-bEwOm

Conversation

@shannah

@shannah shannah commented Mar 8, 2026

Copy link
Copy Markdown
Owner

Summary

Updated the Helper application installation logic to reference "services" instead of "commands" for consistency with the actual service management functionality.

Key Changes

  • Renamed commandsExist variable to servicesExist to better reflect what is being checked
  • Changed the condition from checking allCommands to checking newServiceCommands
  • Updated comments to use "service management" and "services" terminology instead of "command management" and "commands"
  • Simplified the update logic: updateHelperApplication() now receives servicesExist directly instead of always passing true, allowing the Helper to be properly removed when no services exist (during updates)

Implementation Details

  • The Helper application installation now correctly depends on the presence of newServiceCommands rather than allCommands
  • For updates, the Helper removal is now conditional based on whether services exist, whereas previously it was always kept installed
  • Comments clarify that Helper removal only occurs during uninstall operations
  • The logic maintains the same behavior for branch installations (Helper skipped) and fresh installs without services (no action taken)

https://claude.ai/code/session_01YZD1d7n14sQ65gxweMWY8X

The Helper application was being installed for any app with commands,
but it should only be installed when service commands exist. For fresh
installs, changed the check from allCommands to newServiceCommands.
For updates, pass the actual servicesExist flag instead of always true.

https://claude.ai/code/session_01YZD1d7n14sQ65gxweMWY8X
@shannah
shannah merged commit cd460c2 into master Mar 8, 2026
10 checks passed
@shannah
shannah deleted the claude/fix-helper-directory-creation-bEwOm branch March 8, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants