Refactor Helper application logic to use services instead of commands - #428
Merged
Merged
Conversation
The Helper application was being installed for any app with commands, but it should only be installed when service commands exist. For fresh installs, changed the check from allCommands to newServiceCommands. For updates, pass the actual servicesExist flag instead of always true. https://claude.ai/code/session_01YZD1d7n14sQ65gxweMWY8X
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the Helper application installation logic to reference "services" instead of "commands" for consistency with the actual service management functionality.
Key Changes
commandsExistvariable toservicesExistto better reflect what is being checkedallCommandsto checkingnewServiceCommandsupdateHelperApplication()now receivesservicesExistdirectly instead of always passingtrue, allowing the Helper to be properly removed when no services exist (during updates)Implementation Details
newServiceCommandsrather thanallCommandshttps://claude.ai/code/session_01YZD1d7n14sQ65gxweMWY8X