Skip to content

Folder deletion not catched #86 - #130

Open
floz wants to merge 156 commits into
shama:masterfrom
floz:master
Open

floz wants to merge 156 commits into
shama:masterfrom
floz:master

Conversation

@floz

@floz floz commented Jul 1, 2014

Copy link
Copy Markdown

Solving this issue: #86
Tell me what you think about it!

Thanks

shama added 30 commits March 19, 2014 21:14
These tests were for specific cases handled by private methods
that have now been removed and therefore these tests should be removed.
@floz

floz commented Jul 1, 2014

Copy link
Copy Markdown
Author

However those 2 lines (148&149):
Gaze.super_.prototype.emit.apply(self, args);
Gaze.super_.prototype.emit.apply(self, ['all', e].concat([].slice.call(args, 1)));
Cause the this.on( "deleted" ) to fire twice. Is that a normal behavior?

@avanderhoorn

Copy link
Copy Markdown

I'm running into this issue too. +1 for fixing it.

Any news on when it will come in?

@shama

shama commented Jul 6, 2014

Copy link
Copy Markdown
Owner

Thanks for the PR @floz but I'm going to handle this a bit differently. I want to make it an option with deleted as the default, make sure it is cross platform and add tests into the test suite for it.

Re: those 2 lines. The first line emits for the specific event, i.e. deleted, added, changed, etc and the second emits for the all event.

@avanderhoorn

Copy link
Copy Markdown

Thanks for the update!

@floz

floz commented Jul 6, 2014

Copy link
Copy Markdown
Author

Hey Shama,
Cool, thanks for the answer & the explanations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants