feat: idle escrow yield integration — deposit to external yield protocol#148
Merged
Conversation
|
@AJtheManager Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: idle escrow yield integration
lib.rs — 3 new public methods + 1 query:
The external protocol interface is defined via #[contractclient(name = "YieldProtocolClient")] — matching the same pattern as token::Client — with three methods: deposit, withdraw, balance_of.
New DataKey variants: YieldProtocol, YieldDeposited(Address).
test: fuzz testing for milestone percentage validation
property_tests.rs — new milestone_percent_fuzz module with 8 pure-model proptest cases (10 000 cases each) and a nested contract_percent_tests module with 4 contract-backed proptest cases (200 cases each):
Pure model: sum/min invariant, two-split validity, order independence, zero-entry rejection, >100 entry, augmented sum invalidation, uniform n-way split, empty list and exact-min-split edge cases.
Contract-backed: verifies the live contract accepts valid splits, rejects below-minimum percents, rejects non-100 sums, and accepts a single 100% milestone.
feat: batch create multiple independent shipments
lib.rs — new BatchShipmentParams contracttype struct (mirrors all create_shipment params) and batch_create_shipments(env, params: Vec) -> Vec. Atomicity is free — Soroban transactions are all-or-nothing, so any per-shipment validation failure reverts the entire batch. Emits a batch_shipments_created event with the count.
closes #103
closes #88
closes #106
closes #101