fix colors and shapes - #1
Open
williamhickman wants to merge 1 commit into
Open
Conversation
searches/maximum colors and shapes were reversed
Owner
|
Hi, Thanks for this pull request! It's a bit difficult to read because the indentation is changed on every line, but the only relevant change is on line 35? |
Author
|
Sorry about that, I copied and pasted a whole section so it's hard to find what I actually changed. It was just a simple fix (not meaningful for results, just for display purposes) on lines 32, 33, and 35. The maximum info point was supposed to be a pink triangle and all other sampled points were supposed to be black dots, but the code (as previously written) had reversed the colors in the legend and in the actual plot. |
Author
|
The only real change was on line 35. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
searches/maximum colors and shapes were reversed