Skip to content

fix: make snapshot removal consistent - #57

Merged
shakkernerd merged 5 commits into
mainfrom
fix/snapshot-removal-consistency
Jul 23, 2026
Merged

fix: make snapshot removal consistent#57
shakkernerd merged 5 commits into
mainfrom
fix/snapshot-removal-consistency

Conversation

@shakkernerd

Copy link
Copy Markdown
Owner

Summary

  • validate snapshot identity and managed archive paths before removal
  • tombstone snapshot metadata before staging archive content out of live paths
  • preserve post-removal cleanup warnings through direct removal, pruning, rollback, and environment destruction

Why

A linked recovery cleanup failure could occur after snapshot metadata and archive content were already removed. Callers could then report a safety snapshot as retained even though it was unavailable.

Verification

  • AWS Crabbox: cargo test --locked
  • AWS Crabbox: cargo check --locked --all-targets
  • AWS Crabbox: cargo check --locked --target x86_64-pc-windows-gnu
  • frozen OpenClaw 2026.6.11 through 2026.7.2 compatibility evidence remains applicable because runtime and version execution paths are unchanged

@shakkernerd
shakkernerd force-pushed the fix/snapshot-removal-consistency branch from 13c4761 to 0c79b7b Compare July 23, 2026 09:42
@shakkernerd shakkernerd self-assigned this Jul 23, 2026
@shakkernerd
shakkernerd merged commit a88a4b4 into main Jul 23, 2026
5 checks passed
@shakkernerd

Copy link
Copy Markdown
Owner Author

Merged using rebase.

What changed after review:

  • Reordered snapshot removal so metadata is tombstoned before archive staging, preventing a hard interruption from leaving a visible snapshot without its archive.
  • Confirmed cleanup warnings propagate through direct removal, pruning, rollback recovery, and environment destruction.
  • Confirmed corrupted snapshot identity and foreign archive paths fail before mutation.

Verification:

  • Rebased/refreshed onto current origin/main before pushing.
  • AWS Crabbox: cargo test --locked, cargo check --locked --all-targets, and cargo check --locked --target x86_64-pc-windows-gnu passed at the exact tested tree.
  • Frozen OpenClaw 2026.6.11 through 2026.7.2 compatibility evidence remains applicable because runtime/version execution paths were unchanged.
  • Auto-review: unavailable; equivalent exact-head calibrated review was clean.
  • GitHub checks: Format, Rust 1.88 minimum, Windows compile, Ubuntu tests, and macOS tests passed.

Landed on main:

Thanks @shakkernerd!

@shakkernerd
shakkernerd deleted the fix/snapshot-removal-consistency branch July 23, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant