Skip to content

fix: clean unrecorded rollback snapshots - #56

Merged
shakkernerd merged 4 commits into
mainfrom
fix/cleanup-rollback-audit-failures
Jul 23, 2026
Merged

fix: clean unrecorded rollback snapshots#56
shakkernerd merged 4 commits into
mainfrom
fix/cleanup-rollback-audit-failures

Conversation

@shakkernerd

Copy link
Copy Markdown
Owner

Summary

  • remove a failed rollback safety snapshot when state restoration succeeded but history persistence failed
  • retain safety snapshots when history records them or restoration itself failed
  • report removed snapshots accurately across pretty, raw, and JSON output

Verification

  • reproduced the orphaned-snapshot failure on AWS before the fix
  • AWS Crabbox: cargo test --locked
  • AWS Crabbox: cargo check --locked --all-targets
  • AWS Crabbox: cargo check --locked --target x86_64-pc-windows-gnu
  • AWS Crabbox: all explicit rollback tests plus exact-tip lifecycle and render tests
  • cargo fmt --check
  • git diff --check

@shakkernerd
shakkernerd force-pushed the fix/cleanup-rollback-audit-failures branch from 44cf273 to 91c4a65 Compare July 23, 2026 09:17
@shakkernerd shakkernerd self-assigned this Jul 23, 2026
@shakkernerd
shakkernerd merged commit 8a5c563 into main Jul 23, 2026
5 checks passed
@shakkernerd

Copy link
Copy Markdown
Owner Author

Merged using rebase.

What changed after review:

  • Removed unrecorded safety snapshots after failed rollback attempts that successfully restored the pre-rollback state.
  • Retained recorded snapshots and snapshots needed after failed restoration.
  • Corrected pretty, raw, and JSON reporting for removed safety snapshots.

Verification:

  • Reproduced the orphaned-snapshot failure on AWS before the fix.
  • AWS Crabbox cbx_a55a7013c2d7: full cargo test --locked, all-target checks, and Windows GNU compile passed.
  • Explicit rollback lifecycle tests and exact-tip rendering tests passed.
  • Auto-review: history, snapshot, recovery, cleanup-error, and output branches reviewed clean.
  • GitHub checks: all required checks green on the prepared head.

Landed on main:

Thanks @shakkernerd!

@shakkernerd
shakkernerd deleted the fix/cleanup-rollback-audit-failures branch July 23, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant