Skip to content

fix: serialize complete upgrade operations - #55

Merged
shakkernerd merged 3 commits into
mainfrom
fix/serialize-upgrade-operation
Jul 23, 2026
Merged

fix: serialize complete upgrade operations#55
shakkernerd merged 3 commits into
mainfrom
fix/serialize-upgrade-operation

Conversation

@shakkernerd

Copy link
Copy Markdown
Owner

Summary

  • hold the per-environment operation lock for the complete normal upgrade lifecycle
  • use locked binding, service, snapshot restore, and rollback paths while that lock is held
  • add a process-level regression test proving competing environment mutations wait and then continue

Verification

  • AWS Crabbox: cargo test --locked
  • AWS Crabbox: cargo check --locked --all-targets
  • AWS Crabbox: cargo check --locked --target x86_64-pc-windows-gnu
  • AWS Crabbox: all 42 upgrade integration tests, including the new concurrent-mutation test
  • cargo fmt --check
  • git diff --check

@shakkernerd
shakkernerd force-pushed the fix/serialize-upgrade-operation branch from 8430c8c to 1ab8487 Compare July 23, 2026 09:01
@shakkernerd shakkernerd self-assigned this Jul 23, 2026
@shakkernerd
shakkernerd merged commit 3a76b99 into main Jul 23, 2026
5 checks passed
@shakkernerd

Copy link
Copy Markdown
Owner Author

Merged using rebase.

What changed after review:

  • Held the per-environment operation lock for the complete normal upgrade lifecycle.
  • Used non-relocking binding, service, snapshot restore, and rollback paths while the lock is held.
  • Added process-level coverage for a competing environment mutation waiting and then continuing.

Verification:

  • AWS Crabbox cbx_a55a7013c2d7: full cargo test --locked, all-target checks, and Windows GNU compile passed.
  • All 42 upgrade integration tests passed, including the concurrent-mutation regression.
  • Auto-review: lock ordering, nested mutation paths, rollback recovery, and sibling environment/service callers reviewed clean.
  • GitHub checks: all required checks green on the prepared head.

Landed on main:

Thanks @shakkernerd!

@shakkernerd
shakkernerd deleted the fix/serialize-upgrade-operation branch July 23, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant