-
Notifications
You must be signed in to change notification settings - Fork 1
Configure twin-server change-copy ignores #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
956c0b9
feat(twin-servers): ship default change-copy ignores
rameziophobia 1bdfcd0
feat(twin-servers): ignore host artifacts during auto-sync
rameziophobia 63ce46b
test(twin-servers): cover default and project copy ignores
rameziophobia c43e74f
docs(twin-servers): document host-only copy rules
rameziophobia 85033f7
feat(config): add twin-server copy-ignore overrides
rameziophobia 70971e8
refactor(twin-servers): drive copy ignores from config
rameziophobia 62c84f7
test(twin-servers): cover configured copy-ignore lists
rameziophobia 5bfcd9f
docs(twin-servers): show copy-ignore configuration
rameziophobia 7ddfc0f
fix(twin-servers): ignore audit results during sync
rameziophobia fdc42e5
fix(twin-servers): match auto-sync ignores from git root
rameziophobia 2f15822
fix(config): reject unknown copy-ignore keys
rameziophobia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
packages/shaka-perf/src/twin-servers/__tests__/copy-ignore.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| * Copyright (c) 2026 ShakaCode LLC. | ||
| * | ||
| * This file is part of ShakaPerf. Use is governed by The ShakaPerf | ||
| * License in LICENSE.md. | ||
| */ | ||
|
|
||
| import * as path from 'path'; | ||
| import { | ||
| createCopyIgnoreMatcher, | ||
| isCopyIgnored, | ||
| repositoryRelativeCopyPath, | ||
| } from '../helpers/copy-ignore'; | ||
|
|
||
| describe('copy-ignore paths', () => { | ||
| it('matches repository-relative overrides for events from a nested build context', () => { | ||
| const repositoryRoot = path.join(path.sep, 'repo'); | ||
| const buildRoot = path.join(repositoryRoot, 'packages', 'web'); | ||
| const eventPath = repositoryRelativeCopyPath( | ||
| repositoryRoot, | ||
| buildRoot, | ||
| path.join('tmp', 'traces', 'trace.json'), | ||
| ); | ||
| const matcher = createCopyIgnoreMatcher({ | ||
| folders: ['packages/web/tmp/traces'], | ||
| files: [], | ||
| }); | ||
|
|
||
| expect(eventPath).toBe(path.join('packages', 'web', 'tmp', 'traces', 'trace.json')); | ||
| expect(isCopyIgnored(matcher, eventPath)).toBe(true); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor UX footgun: because
folders/filesare replaced wholesale rather than merged/appended, a project that only wants to add one extra ignored path (e.g.tmp/traces) and writescopyIgnore: { folders: ['tmp/traces'] }silently loses theaudit-results/compare-results/compare-bisect-resultsdefaults — exactly the multi-GB result dirs this PR is meant to keep off the wire. The README example does show repeating the full default list, so this is mitigated by docs, but it's an easy trap since nothing warns when a supplied list omits the defaults. Consider a merge-by-default (with an explicit opt-out) or at least a runtime warning when overriding.