Add demo bisect seed history - #161
Conversation
ReviewVerified the actual net diff (2 files, +42/-1) matches the PR description. Both changes look intentional and internally consistent with the stated bisect-fixture goal, but one maintainability concern stands out:
The codebase already has a convention for this exact situation — The new Suggest renaming to something self-evidently synthetic (e.g. Everything else — the hero gradient color swap (visual-regression fixture) and the new docs file — is low-risk and consistent with the described bisect-seed-history design. |
| import LazySection from '../shared/LazySection'; | ||
| import ExperimentA11yRegressions from '../shared/ExperimentA11yRegressions'; | ||
|
|
||
| const runMerchandisingWarmup = () => { |
There was a problem hiding this comment.
This is a deliberate 450ms main-thread busy-loop planted as a git-bisect perf-regression fixture (per docs/git-bisect-seed-history.md), but nothing here signals that. The name reads as real merchandising logic, and there's no comment or marker (unlike ExperimentA11yRegressions.tsx, which is clearly named/commented/tagged as an intentional fixture).
Recommend renaming to something self-evidently synthetic (e.g. simulateHomepagePerfRegression) and adding a comment pointing at the bisect-seed-history doc, so a future reader doesn't mistake this for a real bug or delete it without realizing it's load-bearing for a specific checkpoint.
Summary
Stack
This PR is stacked on #160 so its review shows only the eight demo seed-history commits. Once #160 merges, this PR can be rebased or retargeted to
main.Review note
The granular commit sequence is part of the feature: compare-bisect needs distinct historical checkpoints to locate the seeded regressions. The final net diff is two files.