Skip to content

Fix kv2 read version params #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Varjoissa wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Fix kv2 read version params #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef21551
fix: kv2 read version searchparams
May 23, 2026
b43b805
fix: indentation
May 23, 2026
8dae710
fix: indentation
May 23, 2026
6405d0e
chore: added changeset
May 23, 2026
33feac4
chore: added zod validation in the refine block to match the schema v…
May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/itchy-pots-start.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@litehex/node-vault": patch
---

Fixed issue in kv2 read method where version params caused misformed urls. See issue #109
10 changes: 7 additions & 3 deletions src/engine/kv2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,18 @@ export class Kv2 extends ApiSector {
method: 'GET',
path: '/{{mountPath}}/data/{{path}}',
client: this.client,
refine: (init, args) => {
if (args?.version !== undefined) {
const version = z.number().int().positive().parse(args.version);
init.url.searchParams.set('version', String(version));
}
return init;
},
schema: {
path: z.object({
mountPath: z.string(),
path: z.string()
}),
searchParams: z.object({
version: z.number().optional()
}),
response: SuccessResponseSchema.extend({
data: z.object({
data: z.record(z.string(), z.string()),
Expand Down