Fix dependency issues - #10
Open
Trybnetic wants to merge 2 commits into
Open
Conversation
added 2 commits
April 16, 2021 10:31
…s to latest versions that work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changes in the
numpyAPI caused the code to crash. This PR solves that problem in two ways:I suggest (1) to prevent future users running into the same problem. Having fixed versions also reduces the search for API changes that break the code.
With (2) the code is now relatively up to date again. I tested the code with python 3.7 in a conda environment. I guess it also works for newer python versions, but that has not been tested.
This PR should also solve #7 and #8.
I have not checked whether the code still produces the same results as before (but I assume so) as I do not have previous results.