fix void-returning meta_ext_inst SPIR-V emission - #60
Open
abbator wants to merge 67 commits into
Open
Conversation
Currently, only triangle output mode is supported; the corresponding ExecutionMode annotation is ignored. Also, it is not technically possible to emit anything yet, as the member annotations for the position array are not supported yet.
This is a bugfix, we need a size to generate the memory layout.
This change is crucial to getting mesh shaders to work: The way we get this to work for now is by requiring the input shader do annotate a struct member with BuiltIn Position so we can pass this field down into the output shader.
meta_ext_inst unconditionally sets has_result=true in the ExtOpDef, which causes void-returning SPIR-V instructions (e.g. OpImageWrite) to be emitted with a spurious result type and result ID. This produces malformed SPIR-V that fails spirv-val. Check whether the LLVM return type is void (unit_type) and set has_result=false with result_t=NULL accordingly, so the backend emits spvb_no_result for these instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meta_ext_inst unconditionally sets has_result=true in the ExtOpDef, which causes void-returning SPIR-V instructions (e.g. OpImageWrite) to be emitted with a spurious result type and result ID. This produces malformed SPIR-V that fails spirv-val.
Check whether the LLVM return type is void (unit_type) and set has_result=false with result_t=NULL accordingly, so the backend emits spvb_no_result for these instructions.