Feature/macos client#2
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b086990a4f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| } | ||
| fn webui_url(port: u16, home: &Path) -> String { | ||
| let setup_url = format!("http://localhost:{port}/?setup=1"); |
There was a problem hiding this comment.
Avoid forcing setup for configured launches
When a macOS user launches the installed app after completing configuration, this always opens /?setup=1, and App.tsx treats that query as a hard force into the setup wizard even when /config/readiness returns complete; the only code path that removes the query is handleSetupReadinessChanged, which does not run on the initial readiness fetch. This makes normal app launches land on the first-run setup flow instead of the agent workspace. Only add setup=1 for true first-run/unconfigured launches, or have the WebUI clear it once readiness is complete.
Useful? React with 👍 / 👎.
Summary
cargo xtask package macos, installingDaat Locus.appto/Applicationsand adaat-locusCLI wrapper to/usr/local/bin.Daat Locus..pkgartifacts.Verification
cargo fmt --checkcargo test -p xtask --lockedbun run typecheckcargo check --workspace --lockedcargo run -p xtask -- package macos --skip-buildpkgutil --payload-files target/aarch64-apple-darwin/release/macos/daat-locus-0.2.0-aarch64-apple-darwin.pkgDistributioncontains<title>Daat Locus</title>