Make man/po update-po more robust#1647
Merged
Merged
Conversation
There were some inconsistencies in how remove-potcdate was named. It exists as po/remove-potcdate.sin. The man/po tried to copy that in, but it referred to it as remove-potcdate.sed. Just copy it in as remove-potcdate.sed. I think we can do better than this, but for now this should make update-po more robust. Signed-off-by: Serge Hallyn <serge@hallyn.com>
alejandro-colomar
approved these changes
Jun 16, 2026
alejandro-colomar
left a comment
alejandro-colomar
left a comment
Collaborator
There was a problem hiding this comment.
I didn't test, but I guess it works. I don't understand this enough to say I've reviewed it. Feel free to merge. :)
Collaborator
|
I can confirm it works for me: alx@devuan:~/tmp/shadow$ history | tail -n11
1989 git clone https://github.com/hallyn/shadow.git
1990 cd shadow/
1991 git lago
1992 git switch 2026-06-16/potcdate
1993 ./autogen.sh
1994 make -j4
1995 git status
1996 make dist -j4
1997 git status
1998 git status | grep pot$
1999 history | tail -n11
alx@devuan:~/tmp/shadow$ git status | grep pot$
modified: man/po/shadow-man-pages.pot
modified: po/shadow.potThus (posthumously): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some inconsistencies in how remove-potcdate was named. It exists as po/remove-potcdate.sin. The man/po tried to copy that in, but it referred to it as remove-potcdate.sed.
Just copy it in as remove-potcdate.sed. I think we can do better than this, but for now this should make update-po more robust.