src/login_nopam.c: Simplify some code#1643
Open
alejandro-colomar wants to merge 12 commits into
Open
Conversation
Calling strcaseeq() explicitly is more readable, and it allows removing the comments. The code becomes simpler. Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar
changed the title
Signed-off-by: Alejandro Colomar <alx@kernel.org>
This simplifies the conditionals, allowing the removal of 'else's. Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
This will allow reducing indentation for the rest of the code. Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar
force-pushed
the
sm
branch
5 times, most recently
from
63eaa26 to
1012790
Compare
Signed-off-by: Alejandro Colomar <alx@kernel.org>
And rename the iterator to the usual 'i'. Signed-off-by: Alejandro Colomar <alx@kernel.org>
This makes the logic more readable, and removes one variable. Signed-off-by: Alejandro Colomar <alx@kernel.org>
line and perm point to the same thing, but perm is more appropriate. Signed-off-by: Alejandro Colomar <alx@kernel.org>
And remove some superfluous braces. Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.