Skip to content

Support internal wheel version suffixes - #1141

Open
ccummingsNV wants to merge 3 commits into
mainfrom
dev/ccummings/falcor2-pip-version-suffix
Open

Support internal wheel version suffixes#1141
ccummingsNV wants to merge 3 commits into
mainfrom
dev/ccummings/falcor2-pip-version-suffix

Conversation

@ccummingsNV

Copy link
Copy Markdown
Contributor

No description provided.

@ccummingsNV
ccummingsNV requested a review from a team as a code owner September 4, 2026 09:42
@ccummingsNV
ccummingsNV requested review from bmillsNV and removed request for a team September 4, 2026 09:42
@github-actions
github-actions Bot removed the request for review from bmillsNV September 4, 2026 09:42
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 59aa0de2-7fce-4954-bd53-88e48e09f792

📥 Commits

Reviewing files that changed from the base of the PR and between 7b00ff2 and 5b89953.

📒 Files selected for processing (1)
  • setup.py

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The setup script appends the optional SLANGPY_VERSION_SUFFIX environment variable to the package version after determining the base version from version macros or an override.

Changes

Release versioning

Layer / File(s) Summary
Version computation
setup.py
The computed version now appends SLANGPY_VERSION_SUFFIX. The suffix defaults to an empty string when unset.

Merge Risk: ⚪ Minimal · up to 5b899

Package builds can now append an optional internal version suffix while preserving existing version output when no suffix is provided. No merge-blocking production risk is evident.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so the description does not provide enough information to assess its relation to the changeset. Add a short description that explains how setup.py appends SLANGPY_VERSION_SUFFIX to the wheel version.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding support for internal wheel version suffixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 181a318c-a5a3-4b43-b85d-c1802288f26d

📥 Commits

Reviewing files that changed from the base of the PR and between 19625ad and 7b00ff2.

📒 Files selected for processing (1)
  • setup.py

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

Comment thread setup.py Outdated
@coderabbitai
coderabbitai Bot requested a review from bmillsNV September 4, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants