Skip to content

Add release wheel notice staging - #1134

Closed
ccummingsNV wants to merge 1 commit into
mainfrom
dev/ccummings/falcor2-pip-wheel-notices
Closed

Add release wheel notice staging#1134
ccummingsNV wants to merge 1 commit into
mainfrom
dev/ccummings/falcor2-pip-wheel-notices

Conversation

@ccummingsNV

Copy link
Copy Markdown
Contributor

No description provided.

@ccummingsNV
ccummingsNV requested a review from a team as a code owner September 3, 2026 11:52
@ccummingsNV
ccummingsNV requested review from bmillsNV and removed request for a team September 3, 2026 11:52
@jhelferty-nv
jhelferty-nv removed the request for review from bmillsNV September 3, 2026 11:52
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: c13338da-dbe3-4fca-88d4-09bf4f44e6f1

📥 Commits

Reviewing files that changed from the base of the PR and between f31158d and 3521401.

📒 Files selected for processing (2)
  • CMakeLists.txt
  • setup.py

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting


📝 Walkthrough

Walkthrough

Release wheel builds now enable a CMake option that validates and installs third-party license notices for Slang, graphics dependencies, Vulkan-Headers, and OptiX versions.

Changes

Release wheel license notices

Layer / File(s) Summary
Third-party notice installation
CMakeLists.txt
Adds the release-wheel option and installs renamed license notices for Slang, DXC, WinPix, AgilitySDK, NVAPI, Vulkan-Headers, and OptiX versions 8.0, 8.1, and 9.0. Missing files or unpopulated dependencies cause a fatal CMake error.
Release-wheel configuration wiring
setup.py
Enables SLANGPY_BUILD_RELEASE_WHEEL during release-wheel CMake configuration.

Suggested reviewers: skallweitnv


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from skallweitNV September 3, 2026 11:53
@ccummingsNV ccummingsNV closed this Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants