Add hash append utility - #1129
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughChangesHash append API
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This localized API addition does not introduce an actionable merge-blocking risk and is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tdavidovicNV
force-pushed
the
dev/tdavidovic/hash_append
branch
2 times, most recently
from
August 31, 2026 04:58
80aebfa to
7d3bced
Compare
tdavidovicNV
force-pushed
the
dev/tdavidovic/hash_append
branch
from
August 31, 2026 05:20
7d3bced to
ffce1c6
Compare
skallweitNV
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sgl::hash_append()for appending one or more typed values to an existing hashhash_combine()focused on combining already-computed hash valuesValidation
cmake --preset windows-msvc --freshcmake --build --preset windows-msvc-release --target sgl_testspre-commit run --all-files