Skip to content

Add hash append utility - #1129

Merged
tdavidovicNV merged 2 commits into
mainfrom
dev/tdavidovic/hash_append
Sep 3, 2026
Merged

Add hash append utility#1129
tdavidovicNV merged 2 commits into
mainfrom
dev/tdavidovic/hash_append

Conversation

@tdavidovicNV

@tdavidovicNV tdavidovicNV commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add sgl::hash_append() for appending one or more typed values to an existing hash
  • keep hash_combine() focused on combining already-computed hash values

Validation

  • cmake --preset windows-msvc --fresh
  • cmake --build --preset windows-msvc-release --target sgl_tests
  • pre-commit run --all-files

@tdavidovicNV
tdavidovicNV requested a review from a team as a code owner August 30, 2026 14:54
@tdavidovicNV
tdavidovicNV requested review from bmillsNV and removed request for a team August 30, 2026 14:54
@jhelferty-nv
jhelferty-nv removed the request for review from bmillsNV August 30, 2026 14:54
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 866c11a0-2f1c-4803-8b2d-efbee97081b0

📥 Commits

Reviewing files that changed from the base of the PR and between 7d3bced and ffce1c6.

📒 Files selected for processing (1)
  • src/sgl/core/hash.h

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Hash append API

Layer / File(s) Summary
Add variadic hash append
src/sgl/core/hash.h
Adds the public hash_append function template. It combines a seed with one or more hashed values using hash_combine and a fold expression.

Suggested reviewers: bmillsnv, skallweitnv

Merge Risk: ⚪ Minimal · up to 0ca1c

This localized API addition does not introduce an actionable merge-blocking risk and is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding a hash append utility.
Description check ✅ Passed The description directly explains the new sgl::hash_append() function and includes validation details.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested review from bmillsNV and skallweitNV August 30, 2026 14:55
@tdavidovicNV
tdavidovicNV force-pushed the dev/tdavidovic/hash_append branch 2 times, most recently from 80aebfa to 7d3bced Compare August 31, 2026 04:58
@tdavidovicNV
tdavidovicNV force-pushed the dev/tdavidovic/hash_append branch from 7d3bced to ffce1c6 Compare August 31, 2026 05:20
@tdavidovicNV
tdavidovicNV enabled auto-merge (squash) September 3, 2026 13:49
@tdavidovicNV
tdavidovicNV merged commit 7ff1ba4 into main Sep 3, 2026
16 checks passed
@tdavidovicNV
tdavidovicNV deleted the dev/tdavidovic/hash_append branch September 3, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants