Fix derived function reflection hot reload - #1086
Draft
ccummingsNV wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ccummingsNV
force-pushed
the
dev/ccummings/hotreload-fix
branch
from
July 31, 2026 20:30
cfd95d4 to
58ac063
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Layout hot reload refreshed named functions, but overload and specialization objects are created outside the named-function cache. Those live objects therefore retained invalid low-level reflection after device hot reload, which could terminate Python when Falcor2 reused a specialized path-tracer function.
Keeping the derivation tree on
Functionlets each refreshed parent repair its existing children. If the corresponding overload, specialization, or argument type no longer exists, the child remains invalid as expected.Validation
slangpy_ext,falcor2_ext, andfalcor2_testspre-commit run --all-files