Skip to content

tests: gate cooperative-matrix tests on device feature support #12734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvepsalainen-nv wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests: gate cooperative-matrix tests on device feature support #12734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/add.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -Xslang -DBAB

Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/array.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-cuda -Xslang -DBAB
//TEST(compute, metal):COMPARE_COMPUTE(filecheck-buffer=CHECK):-metal -compute -output-using-type -Xslang -DMETAL
Expand Down
2 changes: 1 addition & 1 deletion tests/cooperative-matrix/bfloat16-arith.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -capability spvBFloat16KHR -render-features bfloat16
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -capability spvBFloat16KHR -render-features bfloat16 -render-feature cooperative-matrix

@github-actions github-actions Bot Aug 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Gap (consistency): mixed -render-features / -render-feature on one line

This line now carries both the plural -render-features bfloat16 and the singular -render-feature cooperative-matrix. tools/render-test/options.cpp:154 treats the two spellings as aliases and both split on commas, so this is functionally correct — but mixing them on one directive reads as accidental. tests/cooperative-matrix/fp8.slang:1 has the same pattern (-render-features fp8 -render-feature cooperative-matrix).

Suggestion: collapse into a single plural form — -render-features bfloat16,cooperative-matrix (and -render-features fp8,cooperative-matrix for fp8.slang) — so each line declares its features once.

//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type -capability cuda_sm_8_0

#pragma warning(disable: 41012)
Expand Down
2 changes: 1 addition & 1 deletion tests/cooperative-matrix/bfloat16-comparison.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -capability spvBFloat16KHR -render-features bfloat16
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -capability spvBFloat16KHR -render-features bfloat16 -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type -capability cuda_sm_8_0

#pragma warning(disable: 41012)
Expand Down
2 changes: 1 addition & 1 deletion tests/cooperative-matrix/bfloat16.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type -capability cuda_sm_8_0

// This test exercises using bfloat16 Cooperative Matrix type in matmuladd operation.
Expand Down
2 changes: 1 addition & 1 deletion tests/cooperative-matrix/coherent-load-store-pointer.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST:SIMPLE(filecheck=SPIRV):-stage compute -entry computeMain -target spirv
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -output-using-type -emit-spirv-directly
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -output-using-type -emit-spirv-directly -render-feature cooperative-matrix

// Ensure SPIRV emits coherent operations here
// SPIRV: MakePointerVisible
Expand Down
2 changes: 1 addition & 1 deletion tests/cooperative-matrix/comparison.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type

//DISABLE_TEST(compute):SIMPLE(filecheck=DXIL):-target dxil -profile cs_6_10 -entry computeMain -Xdxc -Ibuild/dxc/include -DBAB
Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/conversion-1.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-cuda -Xslang -DBAB

Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/conversion.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix

//DISABLE_TEST(compute):SIMPLE(filecheck=DXIL):-target dxil -profile cs_6_10 -entry computeMain -Xdxc -Ibuild/dxc/include -DBAB
//DXIL: result code = 0
Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/copyFrom.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -Xslang -DBAB

Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/div.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -Xslang -DBAB

Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/fill.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -entry computeMain
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -entry computeMain -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -entry computeMain -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -entry computeMain -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -entry computeMain
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -entry computeMain -Xslang -DBAB

Expand Down
2 changes: 1 addition & 1 deletion tests/cooperative-matrix/fp8.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -output-using-type -emit-spirv-directly -render-features fp8
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -output-using-type -emit-spirv-directly -render-features fp8 -render-feature cooperative-matrix

// This test exercises using fp8 Cooperative Matrix type in matmuladd operation.
// This currently runs only on Vulkan, as Vulkan only allows using fp8 types in m16k32n16 shape,
Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/inout.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-cuda -Xslang -DBAB

Expand Down
2 changes: 1 addition & 1 deletion tests/cooperative-matrix/length.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHK_VK):-vk -emit-spirv-directly
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHK_VK):-vk -emit-spirv-directly -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHK_CUDA):-cuda

//DISABLE_TEST(compute):SIMPLE(filecheck=DXIL):-target dxil -profile cs_6_10 -entry computeMain -Xdxc -Ibuild/dxc/include
Expand Down
2 changes: 1 addition & 1 deletion tests/cooperative-matrix/load-store-arbitrary-array-vec.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -render-feature cooperative-matrix

// CHECK: 1
// CHECK-NEXT: 2
Expand Down
2 changes: 1 addition & 1 deletion tests/cooperative-matrix/load-store-arbitrary-array.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -render-feature cooperative-matrix

// CHECK: 1
// CHECK-NEXT: 2
Expand Down
2 changes: 1 addition & 1 deletion tests/cooperative-matrix/load-store-groupshared.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda

// CHECK: 1
Expand Down
2 changes: 1 addition & 1 deletion tests/cooperative-matrix/load-store-pointer.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST:SIMPLE(filecheck=SPIRV):-stage compute -entry computeMain -target spirv
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -output-using-type -emit-spirv-directly
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -output-using-type -emit-spirv-directly -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type

// Ensure SPIRV does not do coherent operations here
Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/load-store-rwbyteaddressbuffer.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -output-using-type -emit-spirv-directly
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -output-using-type -emit-spirv-directly -Xslang -DRWBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -output-using-type -emit-spirv-directly -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -output-using-type -emit-spirv-directly -Xslang -DRWBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type -Xslang -DRWBAB

Expand Down
6 changes: 3 additions & 3 deletions tests/cooperative-matrix/load-store-rwstructuredbuffer.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DRWSB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DRWSB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -Xslang -DRWSB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -Xslang -DBAB
Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/load-store.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-cuda -Xslang -DBAB

Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/mat-mul-add.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_CUDA):-cuda -output-using-type

//DISABLE_TEST(compute):SIMPLE(filecheck=DXIL):-target dxil -profile cs_6_10 -entry computeMain -Xdxc -Ibuild/dxc/include -DBAB
Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/mod.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix

//DISABLE_TEST(compute):SIMPLE(filecheck=DXIL):-target dxil -profile cs_6_10 -entry computeMain -Xdxc -Ibuild/dxc/include -DBAB
//DXIL: result code = 0
Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/mod1.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
Comment on lines +1 to +2

@coderabbitai coderabbitai Bot Aug 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Keep the added Vulkan directives within 100 columns.

The same added option makes the changed //TEST directives exceed the Slang line-length limit.

  • tests/cooperative-matrix/mod1.slang#L1-L2: wrap the two Vulkan directives.
  • tests/cooperative-matrix/mul.slang#L1-L2: wrap the two Vulkan directives.
  • tests/cooperative-matrix/out.slang#L1-L2: wrap the two Vulkan directives.
  • tests/cooperative-matrix/parameter.slang#L1-L2: wrap the two Vulkan directives.
  • tests/cooperative-matrix/return.slang#L1-L2: wrap the two Vulkan directives.
  • tests/cooperative-matrix/scalar-mul.slang#L1-L2: wrap the two Vulkan directives.
  • tests/cooperative-matrix/struct.slang#L1-L2: wrap the two Vulkan directives.
  • tests/cooperative-matrix/sub.slang#L1-L2: wrap the two Vulkan directives.
  • tests/cooperative-matrix/subscript-in-func.slang#L1-L2: wrap the two Vulkan directives.
  • tests/cooperative-matrix/subscript.slang#L1-L2: wrap the two Vulkan directives.

As per coding guidelines, follow a 100-column line limit in Slang files.

📍 Affects 10 files
  • tests/cooperative-matrix/mod1.slang#L1-L2 (this comment)
  • tests/cooperative-matrix/mul.slang#L1-L2
  • tests/cooperative-matrix/out.slang#L1-L2
  • tests/cooperative-matrix/parameter.slang#L1-L2
  • tests/cooperative-matrix/return.slang#L1-L2
  • tests/cooperative-matrix/scalar-mul.slang#L1-L2
  • tests/cooperative-matrix/struct.slang#L1-L2
  • tests/cooperative-matrix/sub.slang#L1-L2
  • tests/cooperative-matrix/subscript-in-func.slang#L1-L2
  • tests/cooperative-matrix/subscript.slang#L1-L2

Source: Coding guidelines

//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -Xslang -DBAB

Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/mul.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -Xslang -DBAB

Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/out.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-cuda -Xslang -DBAB

Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/parameter.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-cuda -Xslang -DBAB

Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/return.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-cuda -Xslang -DBAB

Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/scalar-mul.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-cuda -Xslang -DBAB

Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/struct.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-cuda -Xslang -DBAB
//TEST(compute, metal):COMPARE_COMPUTE(filecheck-buffer=CHECK):-metal -compute -output-using-type -Xslang -DMETAL
Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/sub.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -Xslang -DBAB

Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/subscript-in-func.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-cuda -Xslang -DBAB

Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/subscript.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -Xslang -DBAB

Expand Down
4 changes: 2 additions & 2 deletions tests/cooperative-matrix/unary_neg.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-vk -emit-spirv-directly -output-using-type -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-vk -emit-spirv-directly -Xslang -DBAB -render-feature cooperative-matrix
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK):-cuda -output-using-type
//TEST(compute):COMPARE_COMPUTE(filecheck-buffer=CHECK_BAB):-cuda -Xslang -DBAB

Expand Down
Loading
Loading