Listen to changes in user selection - #4
Closed
eynimeni wants to merge 5 commits into
Closed
Conversation
Owner
|
Thanks a lot for your contribution! The changes look good so far, could you please rebase to the latest version (the check for empty $userids array is already implemented there)? |
sh-csg
self-requested a review
May 6, 2026 07:58
Author
|
@sh-csg thank you for your feedback! rebase is done. I kept your way of handling the empty user array. |
Owner
|
Closing as completed via #5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix to make sure, all users selected in the interface are saved in the condition.
Selection can also happen via keyboard command (like select-all etc)