Only deliver EQNotify alerts to active Raiders#264
Merged
Conversation
Gate batphone dispatch on the subscriber currently holding the Raider role, checked live against Discord at push time. A subscriber who loses the role (goes inactive, leaves the guild) stops receiving alerts without needing to unregister; unresolvable members are treated as non-Raiders. The manual /eqnotify test path is intentionally unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BWXRmPbtEz35wquwFd8Cu7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #263 (EQNotify). Gates batphone dispatch on the subscriber currently holding the Raider role, checked live against Discord at push time.
A subscriber who loses the role (goes inactive, leaves the guild, etc.) stops receiving alerts without having to
unregister. Members that can't be resolved (e.g. they've left) are treated as non-Raiders and skipped.Changes
dispatch()now resolves each tag-matching subscriber viagetMember()and only delivers if they holdraiderRoleId. Failures to resolve are fail-closed./eqnotify testcommand is intentionally unaffected, since it's a self-check that a user's device/chat ID works./eqnotify registerconfirmation and the README.Testing
yarn tsc— clean.yarn test:ci(eqnotify matcher suite) — 11 tests pass.🤖 Generated with Claude Code
Generated by Claude Code