Make generated db:generate use PGlite by default#46
Open
CyrusAuyeung wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pgstrap initscaffolddb:generateaspgstrap generate --pglite, so generated projects can runbun run db:generatewithout a local Postgres server.db:generate:postgresas an explicit script for the original real-Postgres generation path.Why this shape
@seveibar I noticed a few existing attempts for this issue. This keeps the CLI default unchanged to avoid surprising existing
pgstrap generateusers, while making newly initialized projects satisfy #2 out of the box. It also preserves the Postgres path with a named script instead of changing global generate semantics.If this smaller approach is the direction you prefer and it gets merged, could this be considered for the Algora bounty on #2?
Verification
npm exec --yes bun -- testThe system cannot find the path specified.messages from the migration tooling, but the test process exited successfully.npm exec --yes bun -- run buildnpm exec --yes bun -- x biome format README.md src/init.ts tests/init.test.tsgit diff --checkFixes #2
@algora-pbc /claim #2