Port code to Python 3 and dnspython 2.0.0.#5
Open
pabs3 wants to merge 5 commits into
Open
Conversation
Use of sys.exc_type is discouraged and has been removed in Python 3. sys.exc_info is thread-safe.
basestring has been removed in Python 3.
Under Python 3, whelk requires bytes be sent to the command.
Contributor
Author
|
FTR, I haven't tested that this still works with Python 2 as I don't have a Python 2 setup where I can install dnspython any more, but I have tried to ensure that all the changes are compatible with Python 2 and older versions of dnspython. |
Under Python 3 they are separate types that are not subscriptable, but the code needs to be able to do that. Co-authored-by: @LatinSuD
The query() function is deprecated since dnspython 2.0.0. Add a fallback for older versions of dnspython without resolve().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1