Skip to content

fix(desktop): use explicit info button instead of row tap gesture #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seungwonme merged 1 commit into from
Jul 4, 2026
Merged

fix(desktop): use explicit info button instead of row tap gesture #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions apps/desktop/Sources/SkimDesktopApp/ContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,13 @@ struct ContentView: View {
.font(.caption2.weight(.bold))
.foregroundStyle(Design.amber)
}
Button {
openSourcePage(source)
} label: {
Image(systemName: "info.circle")
}
.buttonStyle(.borderless)
.help("유튜브 채널 정보 열기")
Comment on lines +686 to +692

@gemini-code-assist gemini-code-assist Bot Jul 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

⚠️ 툴팁 메시지 개선 제안

TrackedSource는 유튜브(youtube) 외의 다른 플랫폼도 지원할 수 있으며, openSourcePage(_:) 메서드에서도 source.platform == "youtube"가 아닐 경우 handleOrURL을 통해 해당 플랫폼의 웹페이지를 열도록 분기 처리되어 있습니다.

따라서 툴팁(.help) 메시지를 "유튜브 채널 정보 열기"로 고정하면, 유튜브가 아닌 다른 플랫폼의 소스일 때 사용자에게 오해를 불러일으킬 수 있습니다.

플랫폼에 따라 툴팁 메시지를 동적으로 변경하도록 수정하는 것을 권장합니다.

Suggested change
Button {
openSourcePage(source)
} label: {
Image(systemName: "info.circle")
}
.buttonStyle(.borderless)
.help("유튜브 채널 정보 열기")
Button {
openSourcePage(source)
} label: {
Image(systemName: "info.circle")
}
.buttonStyle(.borderless)
.help(source.platform == "youtube" ? "유튜브 채널 정보 열기" : "소스 페이지 열기")

Button(role: .destructive) {
pendingDeleteSource = source
} label: {
Expand All @@ -694,10 +701,6 @@ struct ContentView: View {
.padding(.horizontal, 10)
.padding(.vertical, 8)
.background(Design.panelBackground.opacity(0.72), in: RoundedRectangle(cornerRadius: 8))
.contentShape(Rectangle())
.onTapGesture {
openSourcePage(source)
}
}

private func openSourcePage(_ source: TrackedSource) {
Expand Down
Loading