Repository navigation
Native-feel CSS polish: lock chrome selection, thin scrollbars, no rubber-banding - #52
Merged
Merged
Conversation
…er-banding - Global user-select/user-drag lock with explicit re-enable for inputs, contenteditable, the entry editor and the data-dir path (#28). - html/body overflow hidden + overscroll-behavior none so only inner panes scroll. - Thin 6px overlay-style webkit scrollbars with subtle thumbs (#28). Co-authored-by: setzor <setzor@users.noreply.github.com>
…ndow even if boot fails - The global user-select/user-drag lock also hit editor descendants; re-enable text selection and native drag inside [contenteditable] and .entry-editor so table cells, paragraphs and canvas-block dragging (draggable: true) keep working. - revealWindow now runs even when boot() rejects, otherwise a startup failure would leave the invisible window (visible: false) looking like a dead app. Co-authored-by: setzor <setzor@users.noreply.github.com>
Owner
Author
|
Full-session review sweep (PRs #47–#52) found and fixed two defects in 49d2f67:
Verified non-issues: flushNow return-guard at boot ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user-select: none+-webkit-user-drag: nonelock over all UI chrome, with explicituser-select: textre-enable forinput,textarea,[contenteditable="true"], the entry editor, and the app-settings data-dir path — so dragging in the sidebar/toolbar/calendar no longer highlights text, and images no longer drag like web content, while the editor, cover title, and settings fields keep normal selection.html, bodygetoverflow: hidden+overscroll-behavior: noneso only the inner panes scroll (no whole-window rubber-banding).::-webkit-scrollbarstyling with subtle translucent thumbs (very visible on WebKitGTK/Linux).Verification
pnpm test— 20 files, 93 tests passed (context-menu Copy/Select-all and editor selection tests unaffected).pnpm buildpasses; inner panes confirmed to scroll independently (overflow-y: autoblocks remain in sidebar/note/shelf panes).Closes #28