Repository navigation
Guard keyboard shortcuts in dialogs/inputs; sync notebook emoji from meta - #49
Merged
Merged
Conversation
…meta - Extract shouldSkipShortcut(): skip t/arrow shortcuts while the shelf popover, delete dialog, or settings overlay is open; skip INPUT, TEXTAREA, SELECT and contenteditable targets (attribute check too); leave arrow keys on buttons for focus movement (#17). - Extract applyNotebookMeta(): onMetaChange now syncs nb.emoji (and handles null) so the in-memory list cannot desync from the manifest after renames/re-fetches (#16). Co-authored-by: setzor <setzor@users.noreply.github.com>
Owner
Author
|
Self-review pass (CodeRabbit-style) over all session changes (PRs #47, #48, and this PR): Fixes applied in 16b24f1:
Verified non-issues:
Checks: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shouldSkipShortcut()insrc/shortcuts.ts. Thet/arrow day navigation now skips when the shelf popover, delete-confirmation dialog, or app-settings overlay is open; skipsINPUT/TEXTAREA/SELECT/contenteditable targets (also checks thecontenteditableattribute, sinceisContentEditableis unreliable in some DOMs); and leaves ArrowLeft/ArrowRight to move focus when aBUTTONhas focus.applyNotebookMeta()insrc/notebookmeta.ts;onMetaChangenow syncsnb.emojifrom fresh backend meta (including clearing onnull), so the in-memory notebook list cannot desync from the manifest after renames or re-fetches.Verification
pnpm test— 20 files, 93 tests passed, including newshortcuts.test.ts(popover/dialog/input/contenteditable/button-arrow cases) andnotebookmeta.test.ts(emoji set/clear/preserve/unknown-id cases).pnpm typecheckandpnpm buildpass.Closes #17
Closes #16