Repository navigation
chore: keep Go sources LF and drop stale roadmap transport deferral - #352
Merged
Merged
Conversation
core.autocrlf=true checks hand-authored Go fixtures out as CRLF, which fails the validate:fixtures gofmt stage. Committed blobs are already LF, so renormalization is a no-op. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 25c59b95-6ae9-4775-bd14-86a11b625d8d
The transport roadmap (#189) is complete and contracts.mdx already says transport builds on callable/vector conformance. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 25c59b95-6ae9-4775-bd14-86a11b625d8d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Two small hygiene fixes from an open-issue triage pass. Neither changes emitter behavior or generated output.
.gitattributes:*.go text eol=lf. Withcore.autocrlf=true, Windows checks out the hand-authored Go vector-adapter fixtures as CRLF, so thevalidate:fixturesgofmt stage fails locally. The committed blobs are already LF.roadmap.mdx. The intro paragraph and item 7 still said to defer HTTP transport projection. That contradictsconcepts/contracts.mdx, and the transport roadmap (feat: track Typra v2 transport producer/consumer roadmap #189) is now closed as complete.Refs #189
Reproduction-first checklist
Typra fixes codegen bugs by turning the reproduction into a permanent test. For any change to emitter
behavior or generated output, confirm:
packages/typra-emitter/fixtures/features/<area>/main.tsp), or an existing one was extended. N/A: no emitter or generated-output change.validate-fixtures.mjsassertion, a golden undergenerated/fixtures/<lang>, and/or a unit test that fails onmainand passes here. N/A.@vector/@sampleencodes input → expected/expectedError. N/A.npm test,npm run validate:fixtures, andnpm run lintpass. Not run: no emitter source changed. CI covers them.type(scope): summary) — it becomes the squash commit and the CHANGELOG entry release-please generates.Notes
Validation, on Windows with
core.autocrlf=true:gofmt -lon tracked.gofiles before the changegit add --renormalize .gofmt -lafter re-checkoutnpm ci && npm run buildindocs/(astro check+ build)id="http-transport"in builtmappings/operationspagepages.ymlbuilds the docs only on pushes to main, so PR CI doesn't cover the docs build. That's why it was run locally.Squash body (so the docs entry survives):