Skip to content

collections.Mapping Errors Fix#87

Open
fauzaanu wants to merge 1 commit into
serverstf:masterfrom
fauzaanu:patch-1
Open

collections.Mapping Errors Fix#87
fauzaanu wants to merge 1 commit into
serverstf:masterfrom
fauzaanu:patch-1

Conversation

@fauzaanu

@fauzaanu fauzaanu commented Nov 5, 2022

Copy link
Copy Markdown

change to collections.abc.Mapping from collections.Mapping as collections.Mapping is deprecated as of now

change to collections.abc.Mapping from collections.Mapping
@lnauta

lnauta commented Jul 9, 2023

Copy link
Copy Markdown

Did this patch myself and thought to merge it into the repo, and found this request is already there!

@sid3windr

Copy link
Copy Markdown

Also just patched this, wanted to bring a PR ;-)

@element-code

Copy link
Copy Markdown

Simply switch to python-a2, as this package is UNMAINTAINED

@sid3windr

Copy link
Copy Markdown

If only that had all the functionality of this library, right?

@Yepoleb

Yepoleb commented Sep 29, 2024

Copy link
Copy Markdown
Member

What's missing?

@sid3windr

Copy link
Copy Markdown

Master server query, as far as I can see. Which was likely not intended to be there, as it's a library implementing the server query protocol...

@Yepoleb

Yepoleb commented Sep 29, 2024

Copy link
Copy Markdown
Member

Oh right, I tried implementing that, but the Steam master server just spits out garbage after a certain point. The only reliable way to query servers is to use a proper steam client library like https://github.com/ValvePython/steam (yes, that's a different package).

@sid3windr

Copy link
Copy Markdown

Thanks for the pointer - for now, for me, python-valve works fine :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants