Tracking Meta PR of all PRs

[pboling]

Update: I've published all of the fixes here, along with many more, as turbo_tests2. It is being extensively tested for compatibility with simplecov v1.

For more information on the friendly hard fork, see: #83

• add --create flag #21
  • 💘 add --create flag VitalConnectInc/turbo_tests#1
• Add option to print failing group #34
  • 💘 Pull 34 VitalConnectInc/turbo_tests#3
• Support parallel_test options: pattern, exclude-pattern & group-by #41
  • 💘 Support parallel_tests options VitalConnectInc/turbo_tests#4
• Add --nice flag #44
  • 💘 Add --nice flag VitalConnectInc/turbo_tests#5
• Support reading .rspec_parallel #45
  • 💘 Support reading .rspec_parallel VitalConnectInc/turbo_tests#6
• Better handle interrupts #46
  • 💘 Better handle interrupts VitalConnectInc/turbo_tests#7
  • Includes suggested change from @ilyazub
• 💘 Code reviews VitalConnectInc/turbo_tests#8
  • Includes https://github.com/serpapi/turbo_tests/pull/45/files#r1456006187 from @ilyazub
• Support custom formatters (such as Fuubar) #51
  • 💘 Handle fuubar VitalConnectInc/turbo_tests#10
• Use PARALLEL_TESTS_EXECUTABLE environmental variable if it's provided #66
  • 💘 Use RSPEC_EXECUTABLE environmental variable if it's provided VitalConnectInc/turbo_tests#11
• Removed unnecessary setup code #67
  • 💘 Removed unnecessary setup code VitalConnectInc/turbo_tests#12
• 💘 🐛 Delay loading of parallel-tests' tasks VitalConnectInc/turbo_tests#14
• Adding changelog with github_changelog_generator gem #59 TBD
• Feature/support profile #64 TBD (WIP)

[pboling]

@ilyazub If you'd be interested in adding a maintainer, I'll apply for the role!

[ilyazub]

@pboling Thanks for all the help! I'll review the PRs and get back you about the maintainer role.

[pboling]

You can see the results of the CI on the fork here: https://github.com/VitalConnectInc/turbo_tests/actions

I expect it to pass here as well, once the workflow is approved.

[pboling]

@ilyazub Update: In light of the following:

• recent release of parallel_tests v5
• lack of rake task
• deep incompatibility with simplecov

I've decided to stop working on this branch. I'll leave it up for others. If the three above issues are not deal breakers for you, this branch does work quite well, and I think it would be a good starting place for further work on this gem.

[pboling]

@ilyazub I think you're going to make a lot more work for yourself if you merge the other PRs individually. It was a lot of work to rebase everything to get it all working together here, and add lots of specs, and get CI passing... and now this PR is in conflict.

In case it wasn't clear, I carefully retained the "authorship" of the original commiters, so merging this does make them all contributors.

[pboling]

@ilyazub FWIW, the PRs I made against my repo where I rebased the original PRs against your repo, are all linked as the nested bullets in the OP description. If you want to use those to individually merge things, it would be easiest if you did them in order, since otherwise the rebasing will get out of sync.

[chaadow]

@pboling Thanks for this meta PR, this comes in clutch for me

[pboling]

@chaadow so glad! FYI, I am no longer involved with that fork, and it might disappear at any time, so if you want it in a reliable state, you should (re)fork it!

[chaadow]

@pboling Oh thanks for letting me know! I'm curious, do you use another gem or another fork perhaps?

[pboling]

I switched back to vanilla parallel_tests (which recently released a v5). The incompatibility with SimpleCov was insurmountable for me, and I didn't have time to fix it. It's not a minor refactor.

btw, I use a gem I made to make configuring SimpleCov easy on every project: kettle-soup-cover - I'm really into code coverage. 🥇

[phyzical]

@pboling quick question, off topic but with parallel v5 is it possible to combine the failures into a single output at the end?

i believe that was our biggest reason to switch over to turbo

[pboling]

I think if you configure the command_name to be unique for each parallel process your results will be auto-merged by SimpleCov.

SimpleCov.start 'rails' do
  command_name "RSpec #{Process.pid}" # or a unique identifier
end

[phyzical]

sorry i think the simplecov did its job from memory

it was around the list of failed test overviews, as you would end up having to scroll through each set when a failure/s occurred.

But on review of parallel, it looks like we might just have to configure it to save to file and just re dump at the end of the test run ourselves if we switch back (was just wondering if something had changed since, but looks like it hasnt)

[pboling]

Yeah, that was the main benefit of turbo_tests. I agree with your analysis 🧐

[pboling]

@ilyazub The hard fork has been published, as we discussed. Happy to merge the projects back together if this becomes a priority for SerpAPI again!
https://github.com/galtzo-floss/turbo_tests2