Christian cbs prioritization#275
Conversation
…protein) hierarchy
|
@123chrisc nice code!
Otherwise logic seems sound Will leave proper review to a dev team member! |
|
Can we get this merged @123chrisc @simonarocco/ |
|
@rahularoradfs Since its on the estimate sheet, multiple AB targets will only be flagged if multiple unique AB targets are selected! So multiple tests that solely target nucleocapsid wouldn't appear, but different combinations with nucleocapsid (e.g. nucleocapsid + whole membrane) could pop-up. I think everything should be good otherwise! |
@123chrisc we can merge, but we are getting rid of estimate prioritization anyways! ;) doesnt really matter |
|
Simona - still matters for research!
On November 9, 2021, simonarocco ***@***.***> wrote:
> Can we get this merged @123chrisc <https://github.com/123chrisc>
> @simonarocco/
>
@123chrisc <https://github.com/123chrisc> we can merge, but we are
getting rid of estimate prioritization anyways! ;) doesnt really
matter
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#275 (comment)-
963754456>, or unsubscribe
<https://github.com/notifications/unsubscribe-
auth/AOZY6JYL4S4O5O4XE3C6VHTULCA37ANCNFSM5GETMWCA>.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-
email&mt=8&pt=524675> or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-
email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
simonarocco
left a comment
simonarocco
left a comment
There was a problem hiding this comment.
lgtm, just one small comment
| 'column_names', | ||
| 'summary_function']) | ||
|
|
||
| #test |
There was a problem hiding this comment.
No I don't think so! Was playing around with using doing merge requests from terminal instead of GitHub desktop. Is this comment still being actually displayed? I thought I had removed it
3 participants
Briefly describe the feature or bug that this PR addresses.
Former estimate prioritization did not account for antibody target hierarchy. I have added the hierarchy as per 2021.07.06 LSR protocol to address pooling issues in CBS report.
Please link the Airtable ticket associated with this PR.
N/A
Describe the steps you took to test the feature/bugfix introduced by this PR.
Reviewed LSR protocol. Added relevant prioritization code.
Does any infrastructure work need to be done before this PR can be pushed to production?
I don't think so